Skip to content

docs: note nightwatch + pnpm 10 users to run pnpm approve-builds after install #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

docs: note nightwatch + pnpm 10 users to run pnpm approve-builds after install #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion utils/generateReadme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,14 @@ See [Vite Configuration Reference](https://vite.dev/config/).

`

let installCommand = commandFor('install')
if (packageManager === 'pnpm' && needsNightwatch) {
// TODO: remove the "for pnpm 10+" note when pnpm 10 is widely adopted
installCommand += `\npnpm approve-builds # for pnpm 10+`
}

let npmScriptsDescriptions = `\`\`\`sh
${commandFor('install')}
${installCommand}
\`\`\`

### Compile and Hot-Reload for Development
Expand Down