packages/runtime-core/src/directives.ts (1)

124-131: Widen directive arg types: update DirectiveArguments and generic Arg in apiCreateApp.ts

DirectiveArguments still forces the arg to string. ripgrep shows remaining generic constraints (Arg extends string) in apiCreateApp.ts — these must be loosened to allow non-string args.

Files to update:

• packages/runtime-core/src/directives.ts — change the tuple variants that force string to accept any.
• packages/runtime-core/src/apiCreateApp.ts — change both occurrences of Arg extends string = string to Arg = any.

Suggested diffs:

--- a/packages/runtime-core/src/directives.ts
+++ b/packages/runtime-core/src/directives.ts
@@
 export type DirectiveArguments = Array<
   | [Directive | undefined]
   | [Directive | undefined, any]
-  | [Directive | undefined, any, string]
-  | [Directive | undefined, any, string | undefined, DirectiveModifiers]
+  | [Directive | undefined, any, any]
+  | [Directive | undefined, any, any, DirectiveModifiers]
 >

--- a/packages/runtime-core/src/apiCreateApp.ts
+++ b/packages/runtime-core/src/apiCreateApp.ts
@@
-  Value = any,
-  Modifiers extends string = string,
-  Arg extends string = string,
+  Value = any,
+  Modifiers extends string = string,
+  Arg = any,
 )(
   name: string,

(Apply the same replacement for the second generic block found near lines 59–63.)

packages/runtime-core/src/directives.ts (1)

38-38: Propagate Modifiers and Arg generics into the dir property for stronger typing

Carrying the generics here preserves the directive’s full type information on the binding (particularly Arg), improving inference in hooks.

Apply this diff:

-  dir: ObjectDirective<any, Value>
+  dir: ObjectDirective<any, Value, Modifiers, Arg>

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

packages/runtime-core/src/apiCreateApp.ts (1)

18-19: Sanity check — lingering Arg extends string found

rg found one remaining occurrence in a DTS test; please remove/update the constraint to avoid partial inconsistency.

• packages-private/dts-test/directives.test-d.ts:16 — Arg extends string = string,

Suggested change:

• Before: Arg extends string = string,
• After: Arg = string,

packages/runtime-core/src/directives.ts (2)

33-39: Consider parameterizing DirectiveBinding.dir to preserve Modifiers and Arg generics.

Currently dir is typed as ObjectDirective<any, Value>, which drops the Modifiers and Arg parameters you now expose via DirectiveBinding. This weakens type propagation to hooks (they’ll default to string and any). If there are no known TS bugs blocking it, tighten it as below to preserve the full generic info:

-  modifiers: DirectiveModifiers<Modifiers>
-  dir: ObjectDirective<any, Value>
+  modifiers: DirectiveModifiers<Modifiers>
+  dir: ObjectDirective<any, Value, Modifiers, Arg>

If this was intentionally wide to avoid prior TS issues (the nearby __mod workaround hints at that), feel free to skip; otherwise this improves type inference end-to-end.

---

124-131: Allowing non-string DirectiveArguments arg is appropriate; consider adding a d.ts test.

The tuple updates to [Directive | undefined, any, any] and [Directive | undefined, any, any, DirectiveModifiers] correctly reflect the loosened Arg. To guard against regression, consider adding a test in directives.test-d.ts asserting HTMLElement is accepted as arg for both object and function directives.

I can add a minimal d.ts test case that uses withDirectives and App.directive with an HTMLElement arg. Want me to draft it?

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these settings in your CodeRabbit configuration.

packages/runtime-core/src/directives.ts (1)

105-113: Sanity check — one lingering Arg extends string found; please widen it

Found one remaining string-constrained Arg in the d.ts test; runtime types and App.directive overloads look fine. Please update the DTS/test typing.

• packages-private/dts-test/directives.test-d.ts:16 — contains Arg extends string = string (change to Arg = any or remove the extends string constraint)
• packages/runtime-core/src/directives.ts: lines ~28, 63, 98, 105 — confirmed DirectiveBinding / ObjectDirective / FunctionDirective / Directive use Arg = any
• packages/runtime-core/src/compat/global.ts:209,212 — App.directive usages found; no narrowing of Arg detected
• packages/runtime-core/tests/directives.spec.ts:24, 159, 213 — tests assert binding.arg runtime value (OK), but update corresponding d.ts if you widen types
• packages/runtime-core/src/index.ts — no re-export narrowing of Directive types found

packages/runtime-core/src/directives.ts (2)

63-96: Add dts coverage for a non-string Arg to prevent regressions

Consider adding a directives.test-d.ts case where Arg is a non-string (e.g., HTMLElement) to lock in this behavior.

Example snippet for dts tests:

import type { ObjectDirective } from '../../src'

type ArgEl = HTMLElement

const vOutside: ObjectDirective<HTMLElement, any, string, ArgEl> = {
  mounted(el, binding) {
    const maybeEl = binding.arg
    // should be HTMLElement | undefined
    const _assert: ArgEl | undefined = maybeEl
  },
}

Would you like me to draft a full test file following the repo’s dts test conventions?

---

31-31: Optional: keep default Arg = string (no extends) to preserve DX while allowing non-string overrides

If you want to retain the common-case ergonomics (binding.arg defaults to string in userland) but still support non-string args when explicitly specified, consider removing the extends constraint but keeping the default as string. This avoids an abrupt widening to any in the default experience, yet remains flexible when a directive chooses a different Arg type.

Apply across the touched declarations:

-interface DirectiveBinding<
-  Value = any,
-  Modifiers extends string = string,
-  Arg = any,
-> {
+interface DirectiveBinding<
+  Value = any,
+  Modifiers extends string = string,
+  Arg = string,
+> {
   ...
-  dir: ObjectDirective<any, Value, Modifiers, Arg>
+  dir: ObjectDirective<any, Value, Modifiers, Arg>
 }

-type DirectiveHook<
+type DirectiveHook<
   HostElement = any,
   Prev = VNode<any, HostElement> | null,
   Value = any,
   Modifiers extends string = string,
-  Arg = any,
+  Arg = string,
 > = ( ... ) => void

-type SSRDirectiveHook<
+type SSRDirectiveHook<
   Value = any,
   Modifiers extends string = string,
-  Arg = any,
+  Arg = string,
 > = ( ... ) => Data | undefined

-export interface ObjectDirective<
+export interface ObjectDirective<
   HostElement = any,
   Value = any,
   Modifiers extends string = string,
-  Arg = any,
+  Arg = string,
 > { ... }

-export type FunctionDirective<
+export type FunctionDirective<
   HostElement = any,
   V = any,
   Modifiers extends string = string,
-  Arg = any,
+  Arg = string,
 > = DirectiveHook<HostElement, any, V, Modifiers, Arg>

-export type Directive<
+export type Directive<
   HostElement = any,
   Value = any,
   Modifiers extends string = string,
-  Arg = any,
+  Arg = string,
 > =
   | ObjectDirective<HostElement, Value, Modifiers, Arg>
   | FunctionDirective<HostElement, Value, Modifiers, Arg>

Note: Keeping DirectiveArguments’ 3rd tuple element as any still allows passing non-string args through withDirectives, while directive authors can opt into a non-string Arg by parameterizing their directive types.

Also applies to: 38-38, 46-46, 57-57, 67-67, 102-102, 109-109

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these settings in your CodeRabbit configuration.

packages-private/dts-test/directives.test-d.ts (1)

35-41: Incorrect modifiers expectation for Modifiers='a' case

When calling testDirective<number, 'a', 'Arg'>(), the modifiers type should only include 'a', not 'a' | 'b'.

Apply:

-    modifiers: Partial<Record<'a' | 'b', boolean>>
+    modifiers: Partial<Record<'a', boolean>>

packages-private/dts-test/directives.test-d.ts (1)

49-55: Duplicate test block; remove to avoid redundancy

This block duplicates the assertion already covered above (Lines 42-48). Removing reduces noise without losing coverage.

Apply:

-  expectType<{
-    value: number
-    oldValue: number | null
-    arg?: 'Arg'
-    modifiers: Partial<Record<'a' | 'b', boolean>>
-  }>(testDirective<number, 'a' | 'b', 'Arg'>())

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these settings in your CodeRabbit configuration.