Skip to content

clippy: fix warnings introduced with Rust 1.89 #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2025

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Aug 7, 2025

This PR fixes a bunch of clippy warnings introduced with Rust 1.89. Most are related to the mismatched lifetime syntaxes lint described in the announcement. Other warnings are from the needless_return, manual_let_else, unnecessary_unwrap, and cloned_ref_to_slice_refs lints.

Additionally, in od I suppressed warnings from the unpredictable_function_pointer_comparisons Rust lint (rust-lang/rust#134536).

@cakebaker cakebaker force-pushed the clippy_fix_warnings_rust_1_89 branch from d71872f to e20eba5 Compare August 7, 2025 14:12
@cakebaker cakebaker marked this pull request as draft August 7, 2025 14:12
Copy link

github-actions bot commented Aug 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker force-pushed the clippy_fix_warnings_rust_1_89 branch from e20eba5 to 10dbffa Compare August 7, 2025 14:42
@cakebaker cakebaker marked this pull request as ready for review August 7, 2025 15:00
Copy link

github-actions bot commented Aug 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker requested a review from sylvestre August 7, 2025 15:10
@sylvestre sylvestre merged commit f36bf1d into uutils:main Aug 7, 2025
90 checks passed
@cakebaker cakebaker deleted the clippy_fix_warnings_rust_1_89 branch August 8, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants