clippy: fix warnings introduced with Rust 1.89
#8446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of clippy warnings introduced with Rust
1.89
. Most are related to the mismatched lifetime syntaxes lint described in the announcement. Other warnings are from the needless_return, manual_let_else, unnecessary_unwrap, and cloned_ref_to_slice_refs lints.Additionally, in
od
I suppressed warnings from theunpredictable_function_pointer_comparisons
Rust lint (rust-lang/rust#134536).