zramctl: fix MEM-USED column description to make it clear it is a peak value #3695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MEM-USED column was incorrectly documented as showing current memory consumption. This is due to confusing naming in the kernel's zram implementation: - Kernel field "mem_used_total" (3rd in mm_stat) = current memory usage - Kernel field "mem_used_max" (5th in mm_stat) = peak memory usage zramctl maps these as: - TOTAL column <= mem_used_total (current usage) - MEM-USED column <= mem_used_max (peak usage) The misleading "MEM-USED" name suggests current usage, but it actually shows the peak memory usage (high water mark) since device creation or last reset. This is tracked by the kernel's max_used_pages which only increases when current usage exceeds the stored maximum. Fixed description from: "memory zram have been consumed to store compressed data" to "peak memory usage to store compressed data". Mise à jour de la traduction française.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MEM-USED column was incorrectly documented as showing current memory consumption. This is due to confusing naming in the kernel's zram implementation:
zramctl maps these as:
The misleading "MEM-USED" name suggests current usage, but it actually shows the peak memory usage (high water mark) since device creation or last reset. This is tracked by the kernel's max_used_pages which only increases when current usage exceeds the stored maximum.