Bugfix/nested context mixup #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make sure to calculate the corrent %endcontext annotation, not just the first that is greater than the next nested %context. To operate correctly during recursion we also need information about the parent %endcontext position Fixes #1034
jgebal
reviewed
Dec 20, 2019
| ut3.ut_annotation( 1, 'suite','Cool', null), | ||
| ut3.ut_annotation( 2, 'suitepath','path', null), | ||
| ut3.ut_annotation( 3, 'context','Level 1', null), | ||
| ut3.ut_annotation( 4, 'name','context_1', null), |
There was a problem hiding this comment.
add some tests in parent context of nested context before/after nested context.
I wonder if this will still work as expected.
There was a problem hiding this comment.
Isn't that already done with nested_contexts test?
jgebal
reviewed
Dec 20, 2019
Using simple parenthesis counter and annotations_by_line
jgebal
reviewed
Dec 20, 2019
| add_annotation_ignored_warning(a_parent, gc_name,'Duplicate annotation %%%.', l_annotation_pos); | ||
| else | ||
| l_result := a_context_names(l_annotation_pos); | ||
| if a_annotations.by_name.exists(gc_name) then |
There was a problem hiding this comment.
This looks really great.
Nice improvement to code readability and functionality.
jgebal
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_context_items