fix(checkbox): add flex to CheckboxRoot to fix alignment issue on Firefox #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tguichaoua
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #992
❓ Type of change
📚 Description
This PR addresses a Firefox-only visual bug where the checkbox icon would shift position when toggled (checked/unchecked), particularly in table rows.
What changed
flexclass to the<CheckboxRoot>component to ensure consistent layout and proper alignment of the checkbox.📸 Screenshots
You can observe the issue on the official demo page (before fix):
https://www.shadcn-vue.com/examples/tasks.html
In Firefox, toggling the checkbox causes a small shift in alignment.
📝 Checklist