Update to Unicode 11 #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis will fail because of #66 |
|
@Manishearth I will try to make time to review this tomorrow. |
|
Thank you so much! Let me know if you have any questions.
…On Tue, Oct 22, 2019, 7:17 PM Riad S. Wahby ***@***.***> wrote:
@Manishearth <https://github.com/Manishearth> I will try to make time to
review this tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#68?email_source=notifications&email_token=AAMK6SGPRP7J6HYSSGHXKDTQP6X3ZA5CNFSM4JD2E4HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ZSZQ#issuecomment-545233254>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK6SHGIFCY7D4JKPRAQSLQP6X3ZANCNFSM4JD2E4HA>
.
|
|
cc @zbraniecki once this PR (and an easy follow-up for unicode 12) land
this crate should be a viable option again for the unified rust icu efforts
On Tue, Oct 22, 2019, 7:17 PM Manish Goregaokar <manishsmail@gmail.com>
wrote:
… Thank you so much! Let me know if you have any questions.
On Tue, Oct 22, 2019, 7:17 PM Riad S. Wahby ***@***.***>
wrote:
> @Manishearth <https://github.com/Manishearth> I will try to make time to
> review this tomorrow.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#68?email_source=notifications&email_token=AAMK6SGPRP7J6HYSSGHXKDTQP6X3ZA5CNFSM4JD2E4HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ZSZQ#issuecomment-545233254>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAMK6SHGIFCY7D4JKPRAQSLQP6X3ZANCNFSM4JD2E4HA>
> .
>
|
|
|
|
Actually, just did have some time to take a quick look, and to me things look fine and appear to correctly implement the new rules. But it might still be useful to get a second set of eyes on this (@mbrubeck ?), because my UAX#29 recollection is slightly rusty at this point (no pun intended), so I could have missed something. |
|
I can review it sometime this week. |
mbrubeck
approved these changes
Oct 29, 2019
93b7dff to
6591535
Compare
6591535 to
df71866
Compare
|
Oh, I didn't notice the approval. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully after this the update to Unicode 12 will be straightforward
r? @kwantam or @mbrubeck