Skip to content

fix crashes on prev_boundary #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2018
Merged

fix crashes on prev_boundary #40

merged 3 commits into from
Mar 20, 2018

Conversation

jmuk
Copy link
Contributor

@jmuk jmuk commented Mar 16, 2018

Fixes #38, #39

@jmuk jmuk mentioned this pull request Mar 20, 2018
Merged
raphlinus
raphlinus reviewed Mar 20, 2018
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

src/grapheme.rs Outdated
@@ -665,7 +669,6 @@ impl GraphemeCursor {
}
}

#[test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching, fixed (was included through manual merging)

@Manishearth Manishearth merged commit 6471399 into unicode-rs:master Mar 20, 2018
@jmuk jmuk mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@raphlinus raphlinus raphlinus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmuk @raphlinus @Manishearth