Skip to content

feat(eslint-plugin): [no-unused-vars] align catch behavior to ESLint 9 #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
+24 −7
Merged

feat(eslint-plugin): [no-unused-vars] align catch behavior to ESLint 9 #8971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/eslint-plugin/src/rules/no-unused-vars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default createRule<Options, MessageIds>({
vars: 'all',
args: 'after-used',
ignoreRestSiblings: false,
caughtErrors: 'none',
caughtErrors: 'all',
};

if (typeof firstOption === 'string') {
Expand Down Expand Up @@ -245,9 +245,7 @@ export default createRule<Options, MessageIds>({
) {
continue;
}
}

if (def.type === TSESLint.Scope.DefinitionType.Parameter) {
} else if (def.type === TSESLint.Scope.DefinitionType.Parameter) {
// if "args" option is "none", skip any parameter
if (options.args === 'none') {
continue;
Expand Down
25 changes: 22 additions & 3 deletions packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,13 @@ foo();
doSomething();
})();
`,
`
{
code: `
try {
} catch (e) {}
`,
`,
options: [{ caughtErrors: 'none' }],
},
'/*global a */ a;',
{
code: `
Expand Down Expand Up @@ -925,7 +928,7 @@ try {
try {
} catch (err) {}
`,
options: [{ vars: 'all', args: 'all' }],
options: [{ vars: 'all', args: 'all', caughtErrors: 'none' }],
},

// Using object rest for variable omission
Expand Down Expand Up @@ -2235,6 +2238,22 @@ try {
definedError('err', '. Allowed unused args must match /^ignore/u'),
],
},
{
code: `
try {
} catch (err) {}
`,
options: [{ caughtErrors: 'all', varsIgnorePattern: '^err' }],
errors: [definedError('err', '. Allowed unused vars must match /^err/u')],
},
{
code: `
try {
} catch (err) {}
`,
options: [{ caughtErrors: 'all', varsIgnorePattern: '^.' }],
errors: [definedError('err', '. Allowed unused vars must match /^./u')],
},

// multiple try catch with one success
{
Expand Down