Skip to content

fix(type-utils): add union type support to TypeOrValueSpecifier #11526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Aug 24, 2025

PR Checklist

Overview

Add union type support to TypeOrValueSpecifier.

🐛

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 24, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 61903a8
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68aac006e3576200081b2de4
😎 Deploy Preview https://deploy-preview-11526--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Aug 24, 2025

View your CI Pipeline Execution ↗ for commit 61903a8

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 21s View ↗
nx run-many -t lint ✅ Succeeded 3m 16s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 17s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-24 07:43:18 UTC

Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (bd9e490) to head (61903a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11526   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files         505      505           
  Lines       51146    51149    +3     
  Branches     8424     8427    +3     
=======================================
+ Hits        46480    46483    +3     
  Misses       4652     4652           
  Partials       14       14           
Flag Coverage Δ
unittest 90.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [only-throw-error] TypeOrValueSpecifier does not handle union
1 participant