Skip to content

chore: remove typings for eslint-plugin-import #11524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MariaSolOs
Copy link
Contributor

PR Checklist

Overview

This is just a QOL change. eslint-plugin-import includes its own types since version 2.32.0, and so there's no need for this shim anymore.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MariaSolOs!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 402112a
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68a8d53bffe6360008b53532
😎 Deploy Preview https://deploy-preview-11524--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Aug 22, 2025

View your CI Pipeline Execution ↗ for commit 402112a

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 16s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 1s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-22 20:44:16 UTC

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angry cat screaming with its eyes closed, firing a large automatic gun in front of a fiery/smoky background. Caption: KILL THEM ALL!!

@kirkwaiblinger kirkwaiblinger merged commit bd9e490 into typescript-eslint:main Aug 22, 2025
66 checks passed
@MariaSolOs MariaSolOs deleted the eslint-plugin-import branch August 22, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants