Skip to content

fix(eslint-plugin): [no-unnecessary-type-conversion] only report ~~ on integer literal types #11517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(eslint-plugin): [no-unnecessary-type-conversion] only report ~~ on integer literal types #11517

wants to merge 1 commit into from
+119 −29

Conversation

mouse0429
Copy link

PR Checklist

Overview

Modified the rule to only report ~~ as unnecessary when applied to integer literal types:

  • ~~5 → Reports as unnecessary ✅ (literal integer)
  • ~~(3 | 4) → Reports as unnecessary ✅ (union of integer literals)
  • ~~1.1 → No report ✅ (decimal literal - meaningful conversion)
  • ~~(2 + 2) → No report ✅ (expression - conservative approach)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mouse0429!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7db7d09
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68a61fbd36f39d00074ce077
😎 Deploy Preview https://deploy-preview-11517--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 20, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit 7db7d09

Command Status Duration Result
nx run-many -t typecheck ❌ Failed 2m 9s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 11s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 17s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-20 19:31:03 UTC

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (369ccab) to head (7db7d09).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11517   +/-   ##
=======================================
  Coverage   90.87%   90.88%           
=======================================
  Files         505      505           
  Lines       51146    51179   +33     
  Branches     8424     8427    +3     
=======================================
+ Hits        46480    46513   +33     
  Misses       4652     4652           
  Partials       14       14
Flag Coverage Δ
unittest 90.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...plugin/src/rules/no-unnecessary-type-conversion.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@injae-kim injae-kim mentioned this pull request Aug 21, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-type-conversion] Unsafe suggestion: removing bitwise ~~ changes semantics for non-integer numbers
1 participant
@mouse0429