Skip to content

feat(typescript-estree): forbid invalid keys in EnumMember #11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(typescript-estree): forbid invalid keys in EnumMember #11497

wants to merge 6 commits into from

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Aug 18, 2025 •
edited by kirkwaiblinger
Loading

This reverts commit 7648622.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 18, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2ac5502
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68a9bf8f2cab45000821f4c5
😎 Deploy Preview https://deploy-preview-11497--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2ac5502

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 11s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 16s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run types:build ✅ Succeeded 9s View ↗
nx run generate-configs ✅ Succeeded 11s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-23 13:31:01 UTC

@fisker
Copy link
Contributor Author

fisker commented Aug 18, 2025

Looks like this is still an issue, #11232 (comment), any idea to fix it?

@fisker
Copy link
Contributor Author

fisker commented Aug 18, 2025

I'm not sure what I did, but CI passes now.

@fisker fisker marked this pull request as ready for review August 18, 2025 20:09
@codecov Codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (bd9e490) to head (2ac5502).

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 65.78% 13 Missing ⚠️

❌ Your patch check has failed because the patch coverage (70.45%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11497      +/-   ##
==========================================
- Coverage   90.87%   90.84%   -0.03%     
==========================================
  Files         505      505              
  Lines       51146    51167      +21     
  Branches     8424     8422       -2     
==========================================
+ Hits        46480    46485       +5     
- Misses       4652     4668      +16     
  Partials       14       14
Flag Coverage Δ
unittest 90.84% <70.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...plugin-internal/src/rules/prefer-ast-types-enum.ts 100.00% <100.00%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 97.79% <100.00%> (-0.02%) ⬇️
...int-plugin/src/rules/prefer-literal-enum-member.ts 98.43% <100.00%> (-1.57%) ⬇️
...ackages/scope-manager/src/referencer/Referencer.ts 97.93% <100.00%> (-0.01%) ⬇️
packages/typescript-estree/src/convert.ts 30.38% <65.78%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisker fisker force-pushed the revert-11493-revert-11232 branch from fe02b99 to 2ac5502 Compare August 23, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: forbid invalid keys in EnumMember
1 participant
@fisker