fix(eslint-plugin): [no-unnecessary-type-conversion] ignore enum members #11490
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @thebolarin! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 3cf00da
☁️ Nx Cloud last updated this comment at |
02c5652 to
566410b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11490 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 505 505
Lines 51146 51159 +13
Branches 8424 8428 +4
=======================================
+ Hits 46480 46493 +13
Misses 4652 4652
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bradzacher
requested changes
Aug 18, 2025
There was a problem hiding this comment.
/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin/src/rules/no-unnecessary-type-conversion.ts
27:12 error Unnecessary conditional, expected left-hand side of `??` operator to be possibly null or undefined @typescript-eslint/no-unnecessary-condition
27:12 error Do not use Type.symbol because it is poorly typed. Use Type.getSymbol() instead @typescript-eslint/internal/no-poorly-typed-ts-props
27:23 error Unnecessary optional chain on a non-nullish value @typescript-eslint/no-unnecessary-condition
there are some lint errors to fix
ac38a26 to
1391151
Compare
1391151 to
be5ba37
Compare
@bradzacher Thanks for the review. I have pushed some changes to fix that |
be5ba37 to
5fc90c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
The
no-unnecessary-type-conversionrule was incorrectly reporting violations when.toString()was called on enum members. While enums may be string-like or number-like under the hood, they are conceptually opaque types in TypeScript.The rule now skips reporting for enum types and enum members by checking their type and symbol flags. This prevents false positives where calling .toString() is valid and sometimes necessary, and avoids conflicts with no-unsafe-enum-comparison