Skip to content

fix(eslint-plugin): [no-non-null-assertion] wrong suggestion on left-hand side of an assignment #11489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(eslint-plugin): [no-non-null-assertion] wrong suggestion on left-hand side of an assignment #11489

wants to merge 6 commits into from
+37 −1

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Aug 16, 2025 •
edited
Loading

PR Checklist

Overview

Avoid suggestions for non-null assertions in assignee positions to prevent invalid auto-fixes.

🐛

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 16, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d2e2ef6
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68a86b4b8c921b000879b297
😎 Deploy Preview https://deploy-preview-11489--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 16, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit d2e2ef6

Command Status Duration Result
nx test eslint-plugin --coverage=false ❌ Failed 5m 9s View ↗
nx test eslint-plugin ❌ Failed 5m 4s View ↗
nx run-many -t lint ✅ Succeeded 3m 25s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 12s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-22 13:14:29 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-non-null-assertion] wrong suggestion on left-hand side of an assignment
1 participant
@y-hsgw