fix(typescript-estree): correct range of import assertion with trailing comma #11478
Conversation
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 7a6f2f2
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11478 +/- ##
==========================================
- Coverage 90.87% 90.87% -0.01%
==========================================
Files 505 505
Lines 51117 51121 +4
Branches 8415 8415
==========================================
Hits 46455 46455
- Misses 4648 4652 +4
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: fisker Cheung <lionkay@gmail.com>
PR Checklist
Overview
Account for possibility of trailing comma in import assertion when converting TS AST to ESTree
Also fix up some tsconfig stuff that broke the ability to use
expectBabelToNotSupportin #11126 (see https://github.com/typescript-eslint/typescript-eslint/pull/11126/files#diff-3875bfe708efc111c8948e62750d6ccd5dfc7844ca223fa3dbcd7edd0a601259)