fix(parser): error when both projectService and project are set
#11333
Conversation
|
Thanks for the PR, @MariaSolOs! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 63d37d4
☁️ Nx Cloud last updated this comment at |
d4979a5 to
a8c4dc1
Compare
There was a problem hiding this comment.
These are just notes from quick preliminary review. I think we have a good path forward but should definitely let other team folks weigh in in #11319.
For now, I'll switch this PR to draft so it doesn't show up on the queue. But we can definitely un-draft it once the issue's discussion is done.
packages/typescript-estree/src/parseSettings/createParseSettings.ts
Outdated
Show resolved
Hide resolved
|
@JoshuaKGoldberg Thanks for the review! I'll wait for further thoughts from other maintainers before I continue working on this :) |
a8c4dc1 to
4ff2bd3
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (55.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11333 +/- ##
==========================================
- Coverage 90.87% 90.87% -0.01%
==========================================
Files 505 505
Lines 51146 51155 +9
Branches 8424 8428 +4
==========================================
+ Hits 46480 46485 +5
- Misses 4652 4656 +4
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4ff2bd3 to
63d37d4
Compare
| @@ -19,6 +19,7 @@ env: | |||
| NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }} | |||
| # This increases the verbosity of the logs for everything, including Nx Cloud, but will hopefully surface more info about recent lint failures | |||
| NX_VERBOSE_LOGGING: false | |||
| TYPESCRIPT_ESLINT_IGNORE_PROJECT_AND_PROJECT_SERVICE_ERROR: true | |||
There was a problem hiding this comment.
I tried setting this variable here but it was undefined when running the tests on CI 🤷🏻♀️
There was a problem hiding this comment.
The problem of setting it here is that then I'm not able to write a test that hits the new error codepath, and so that's why the coverage check is screaming at me.
PR Checklist
projectServiceandprojectare set #11319Overview
As mentioned in the issue, the docs aren't clear of what the parser will use when both
projectServiceandprojectare set. When such case is detected, I think it's better to be explicit about the misconfiguration and error as early as possible.