Skip to content

feat: oauth sdk implementation #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 23, 2024
Merged

feat: oauth sdk implementation #799

merged 15 commits into from
Jul 23, 2024

Conversation

manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Jun 21, 2024 •
edited
Loading

Feature

Create HTTP client for BearerTokenAuthentication in Threadsafe manner

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997 manisha1997 marked this pull request as draft June 21, 2024 13:20
@manisha1997 manisha1997 marked this pull request as ready for review June 24, 2024 16:30
@manisha1997 manisha1997 requested review from AsabuHere and sbansla June 24, 2024 16:30
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 24, 2024
View reviewed changes
twilio/http/bearer_token_http_client.py Outdated
return headers

def is_token_expired(self, token):
decoded_jwt = jwt.decode(token, options={"verify_signature": False})

Check failure

Code scanning / SonarCloud

JWT should be signed and verified

<!--SONAR_ISSUE_KEY:AZBLGOXVG8a3U-2AMI_y-->Don't use a JWT token without verifying its signature. <p>See more on <a href="https://sonarcloud.io/project/issues?id=twilio_twilio-python&issues=AZBLGOXVG8a3U-2AMI_y&open=AZBLGOXVG8a3U-2AMI_y&pullRequest=799">SonarCloud</a></p>
@manisha1997 manisha1997 changed the title chore: oauth sdk implementation feat: oauth sdk implementation Jun 25, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 25, 2024
View reviewed changes
twilio/http/bearer_token_http_client.py Outdated
return headers

def is_token_expired(self, token):
decoded_jwt = jwt.decode(token, options={"verify_signature": False})

Check failure

Code scanning / SonarCloud

JWT should be signed and verified

<!--SONAR_ISSUE_KEY:AZBLGS_s_XlZlWu4vuTh-->Don't use a JWT token without verifying its signature. <p>See more on <a href="https://sonarcloud.io/project/issues?id=twilio_twilio-python&issues=AZBLGS_s_XlZlWu4vuTh&open=AZBLGS_s_XlZlWu4vuTh&branch=oauth-sdk">SonarCloud</a></p>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@manisha1997 manisha1997 changed the base branch from main to 10.0.0-rc July 10, 2024 06:52
AsabuHere
AsabuHere suggested changes Jul 22, 2024
View reviewed changes
AsabuHere
AsabuHere approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manisha1997 manisha1997 merged commit b4c5734 into 10.0.0-rc Jul 23, 2024
9 of 10 checks passed
@manisha1997 manisha1997 deleted the oauth-sdk branch July 23, 2024 10:12
AsabuHere added a commit that referenced this pull request Dec 12, 2024
@AsabuHere
feat: Organizations Api uptake for twilio-python (#815)
6e78c78 
* feat: oauth sdk implementation and organization api uptake (#799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla Awaiting requested review from sbansla

1 more reviewer

@AsabuHere AsabuHere AsabuHere approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manisha1997 @AsabuHere