Bulk action cancel as default #2437
Conversation
|
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
apps/webapp/app/components/BulkActionFilterSummary.tsx (1)
248-250: Decorative icon a11y: add aria-hidden (minor)Since this icon is purely decorative, set aria-hidden to avoid it being announced by screen readers.
- <XCircleIconOutline className="mb-0.5 inline-block size-4 text-error" /> + <XCircleIconOutline className="mb-0.5 inline-block size-4 text-error" aria-hidden="true" />Also, confirm that mixing outline (here) vs solid (Line 162: XCircleIcon for “Root only” false state) is intentional for visual language consistency.
apps/webapp/app/components/primitives/RadioButton.tsx (1)
43-43: Remove no-op Tailwind class (micro clean-up)The "-mt-0" on the description text is a no-op. Removing it trims class noise.
- description: "text-text-dimmed -mt-0 text-left", + description: "text-text-dimmed text-left",apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx (1)
346-347: Add aria-hidden to decorative icons (minor)Prevent announcing icons in labels; the text already conveys meaning.
- <XCircleIcon className="size-4 text-error" /> Cancel runs + <XCircleIcon className="size-4 text-error" aria-hidden="true" /> Cancel runs- <ArrowPathIcon className="size-4 text-blue-400" /> Replay runs + <ArrowPathIcon className="size-4 text-blue-400" aria-hidden="true" /> Replay runsAlso applies to: 357-358
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
apps/webapp/app/components/BulkActionFilterSummary.tsx(2 hunks)apps/webapp/app/components/primitives/RadioButton.tsx(1 hunks)apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Always prefer using isomorphic code like fetch, ReadableStream, etc. instead of Node.js specific code
For TypeScript, we usually use types over interfaces
Avoid enums
No default exports, use function declarations
Files:
apps/webapp/app/components/primitives/RadioButton.tsxapps/webapp/app/components/BulkActionFilterSummary.tsxapps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
We use zod a lot in packages/core and in the webapp
Files:
apps/webapp/app/components/primitives/RadioButton.tsxapps/webapp/app/components/BulkActionFilterSummary.tsxapps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: In the webapp, all environment variables must be accessed through theenvexport ofenv.server.ts, instead of directly accessingprocess.env.
When importing from@trigger.dev/corein the webapp, never import from the root@trigger.dev/corepath; always use one of the subpath exports as defined in the package's package.json.
Files:
apps/webapp/app/components/primitives/RadioButton.tsxapps/webapp/app/components/BulkActionFilterSummary.tsxapps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx
🧬 Code graph analysis (1)
apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx (2)
apps/webapp/app/components/primitives/RadioButton.tsx (1)
RadioGroupItem(112-165)apps/webapp/app/components/BulkActionFilterSummary.tsx (2)
BulkActionAction(22-22)BulkActionAction(23-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
apps/webapp/app/components/BulkActionFilterSummary.tsx (1)
14-14: Swapping to outline variant for Cancel icon — LGTMImporting the 24/outline XCircleIcon and aliasing it is clear and matches the intended visual distinction for “Cancel.”
apps/webapp/app/components/primitives/RadioButton.tsx (1)
42-42: Label alignment tweak looks goodThe -mt-0.5 change improves vertical alignment for the description variant as per the PR objective.
apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.bulkaction.tsx (4)
103-105: Defaulting action search param to "cancel" — aligned with product changeSchema default now matches the new UI default. Good consistency across parsing layers.
343-352: “Cancel runs” moved to first with outline icon — LGTMOrder, id, label, description, and value all reflect the new default. Matches the product intent.
354-363: “Replay runs” option adjusted to second — LGTMSemantics, icon, and copy look correct and consistent with the swapped order.
468-473: Fallback default updated to “cancel” – no residual “replay” assumptions foundI searched the codebase and documentation for any remaining references to a default of “replay” (including literal
default("replay"), parsing helpers, tests, or docs) and found none. Specifically:
CreateBulkActionSearchParamsnow usesBulkActionAction.default("cancel")and there are no occurrences ofBulkActionAction.default("replay").- No tests, examples, or MDX/Markdown docs assume “replay” as the fallback.
- All paths that render or act on bulk actions explicitly check the
actionparam (now defaulting to “cancel”) and route accordingly.This confirms that switching the client/server fallback from “replay” to “cancel” has no unintended breakage.
Main update
Additional tweaks
Before
After