apps/webapp/app/env.server.ts (1)

1063-1065: Add nonnegative guard for EVENT_LOOP_MONITOR_THRESHOLD_MS to avoid accidental negative values

A negative threshold would cause every span to be considered "blocked." Consider constraining this to be ≥ 0.

Apply within this line range:

-  EVENT_LOOP_MONITOR_THRESHOLD_MS: z.coerce.number().int().default(100),
+  EVENT_LOOP_MONITOR_THRESHOLD_MS: z.coerce.number().int().nonnegative().default(100),

Optionally, add a short JSDoc comment here or a note in your env docs/sample to clarify units (milliseconds) and typical values.

apps/webapp/app/eventLoopMonitor.server.ts (2)

4-8: Use type-only import for Context and optionally clamp threshold to ≥ 0

• Type-only import avoids potential value import churn and clarifies intent.
• Clamping defends against misconfiguration even if validation changes upstream.

-import { env } from "./env.server";
-import { context, Context } from "@opentelemetry/api";
+import { env } from "./env.server";
+import { context } from "@opentelemetry/api";
+import type { Context } from "@opentelemetry/api";

-const THRESHOLD_NS = env.EVENT_LOOP_MONITOR_THRESHOLD_MS * 1e6;
+const THRESHOLD_NS = Math.max(0, env.EVENT_LOOP_MONITOR_THRESHOLD_MS) * 1e6;

---

53-64: Record duration/threshold as attributes and simplify startTime computation

Two tweaks improve observability and clarity:

• Add duration and threshold attributes for easier querying/alerting.
• Use a number timestamp from Date.now() to avoid allocating intermediate Date objects.

-    const newSpan = tracer.startSpan(
-      "event-loop-blocked",
-      {
-        startTime: new Date(new Date().getTime() - time),
-        attributes: {
-          asyncType: cached.type,
-          label: "EventLoopMonitor",
-        },
-      },
-      cached.parentCtx
-    );
+    const newSpan = tracer.startSpan(
+      "event-loop-blocked",
+      {
+        // start time in ms since epoch
+        startTime: Date.now() - time,
+        attributes: {
+          asyncType: cached.type,
+          label: "EventLoopMonitor",
+          duration_ms: time,
+          threshold_ms: THRESHOLD_NS / 1e6,
+        },
+      },
+      cached.parentCtx
+    );

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025-07-18T17:49:47.180Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : In the webapp, all environment variables must be accessed through the `env` export of `env.server.ts`, instead of directly accessing `process.env`.

apps/webapp/app/eventLoopMonitor.server.ts (2)

9-10: Capturing parent context in cache looks good

Extending the cache entry with an optional parentCtx is a clean way to propagate parent span context into the synthetic "event-loop-blocked" span. Nicely scoped change with minimal surface area.

---

31-32: Correct place to capture the active context

Grabbing context.active() at before() aligns the blocked work with the execution context of the callback that actually blocked. This should produce intuitive parent-child relationships in traces.