apps/webapp/app/v3/services/replayTaskRun.server.ts (4)

61-67: If a queue override is provided, consider omitting region to avoid conflicting scheduling signals.

When overrideOptions.queue is set, passing region may be redundant or conflicting depending on scheduler semantics.

-    const shouldPassRegion =
-      existingTaskRun.engine === "V2" &&
-      existingEnvironment.type !== "DEVELOPMENT" &&
-      authenticatedEnvironment.type !== "DEVELOPMENT";
+    const shouldPassRegion =
+      existingTaskRun.engine === "V2" &&
+      existingEnvironment.type !== "DEVELOPMENT" &&
+      authenticatedEnvironment.type !== "DEVELOPMENT" &&
+      !overrideOptions.queue;

---

61-67: Make the decision observable with a debug log.

This helps diagnose “why didn’t this replay target a region?” in support scenarios, without changing behavior.

     const region = shouldPassRegion ? (existingTaskRun.workerQueue ?? undefined) : undefined;
+    logger.debug("Region decision for replay", {
+      region,
+      engine: existingTaskRun.engine,
+      sourceEnvType: existingEnvironment.type,
+      targetEnvType: authenticatedEnvironment.type,
+      queueOverride: overrideOptions.queue ?? undefined,
+    });

---

61-67: Add targeted tests around region gating.

Minimal coverage to lock this behavior:

• V1 engine (both envs non-dev) → region omitted
• V2 engine with any dev env → region omitted
• V2 engine with both envs non-dev and workerQueue present → region passed
• V2 engine with queue override → region omitted (if you adopt the suggestion above)

I can draft unit/integration tests for ReplayTaskRunService that stub Prisma and assert the options passed to TriggerTaskService.call. Want me to push a test file?

---

61-67: Only pass region for V2 engines and guard against a nullable workerQueue

To prevent inadvertently forwarding the region for future engine versions (e.g. “V3”) and avoid passing null into the downstream service, replace the current “ignoreRegion” logic with an explicit whitelist for "V2" and coalesce the potentially-null workerQueue to undefined.

Files to update:

• apps/webapp/app/v3/services/replayTaskRun.server.ts (around lines 61–67)

Proposed diff:

-    // Only use the region from the existing run if V2 engine and neither environment is dev
-    const ignoreRegion =
-      existingTaskRun.engine === "V1" ||
-      existingEnvironment.type === "DEVELOPMENT" ||
-      authenticatedEnvironment.type === "DEVELOPMENT";
-    const region = ignoreRegion ? undefined : existingTaskRun.workerQueue;
+    // Only pass region when engine is exactly "V2" and neither environment is DEVELOPMENT
+    const shouldPassRegion =
+      existingTaskRun.engine === "V2" &&
+      existingEnvironment.type !== "DEVELOPMENT" &&
+      authenticatedEnvironment.type !== "DEVELOPMENT";
+    const region = shouldPassRegion
+      ? (existingTaskRun.workerQueue ?? undefined)
+      : undefined;

This ensures:

• Future engines (beyond V2) won’t accidentally inherit the old region behavior.
• The workerQueue field, which may be null, is safely converted to undefined.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.