Skip to content

chore(docker): add registry namespace var to .env.example #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

chore(docker): add registry namespace var to .env.example #2426

merged 1 commit into from
Aug 20, 2025

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Aug 20, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025

⚠️ No Changeset found

Latest commit: c92eaf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025 •
edited
Loading

Walkthrough

Adds a new environment variable to hosting/docker/.env.example: DOCKER_REGISTRY_NAMESPACE=trigger. Includes two preceding comments describing usage for external registries and Docker Hub. No application code or logic changes; only the sample Docker environment configuration is updated.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/docker-namespace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
hosting/docker/.env.example (1)

72-77: Fix dotenv-linter UnorderedKey by moving NAMESPACE above PASSWORD (keep comments with it).

dotdev-linter warns that DOCKER_REGISTRY_NAMESPACE should come before DOCKER_REGISTRY_PASSWORD. Moving the new key (and its explanatory comments) above PASSWORD resolves the warning and keeps related docs together.

 DOCKER_REGISTRY_URL=localhost:5000
 DOCKER_REGISTRY_USERNAME=registry-user
-DOCKER_REGISTRY_PASSWORD=very-secure-indeed
-# When using an external registry you will have to change this
-# On Docker Hub it should generally be the same as your username
-DOCKER_REGISTRY_NAMESPACE=trigger
+# When using an external registry you will have to change this
+# On Docker Hub it should generally be the same as your username
+DOCKER_REGISTRY_NAMESPACE=trigger
+DOCKER_REGISTRY_PASSWORD=very-secure-indeed
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b41129a and c92eaf2.

📒 Files selected for processing (1)
  • hosting/docker/.env.example (1 hunks)
🧰 Additional context used
🪛 dotenv-linter (3.3.0)
hosting/docker/.env.example

[warning] 77-77: [UnorderedKey] The DOCKER_REGISTRY_NAMESPACE key should go before the DOCKER_REGISTRY_PASSWORD key

(UnorderedKey)

🔇 Additional comments (1)
hosting/docker/.env.example (1)

75-77: All Docker image references properly use DOCKER_REGISTRY_NAMESPACE; no hard-coded “trigger/” paths found.

No further changes needed.

@nicktrn nicktrn merged commit da79c2b into main Aug 20, 2025
31 checks passed
@nicktrn nicktrn deleted the chore/docker-namespace branch August 20, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ericallam ericallam ericallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicktrn @ericallam