-
-
Notifications
You must be signed in to change notification settings - Fork 791
chore(docs): update bun guide #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicktrn
commented
Aug 20, 2025
- removed incorrect version info
- fixed node cli warning that wasn't displaying before
- moved known issues to the top
- also removed references to snippets that don't exist anymore across the docs
|
WalkthroughAcross several MDX docs, snippet imports/usages related to upgrade and troubleshooting notes were removed. Specifically, UpgradeToV4Note was removed from two Lightpanda docs, and WorkerFailedToStartWhenRunningDevCommand imports/usages were removed from Next.js and Supabase guides (imports only in the Supabase files). The Bun framework guide was updated: description revised, Bun-version-specific warning replaced with a single warning about CLI support (Node.js required), a Known issues section about OpenTelemetry limitations with Bun was added, and a duplicate Known issues section at the end was removed. No exported/public entities were changed. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/guides/frameworks/bun.mdx (2)
12-15
: Clarify Node vs Bun usage in CLI warning; fix brand capitalization; advise against bunxTighten wording and prevent confusion for Bun users.
Apply this diff:
<Warning> - The trigger.dev CLI does not yet support Bun. So you will need to run the CLI using Node.js. + The Trigger.dev CLI does not yet support Bun. You must run the CLI using Node.js. Bun will still be used to execute your tasks, even in the `dev` environment. + Use npx/pnpm dlx/yarn dlx (Node) for the commands below; do not use bunx for the CLI. </Warning>
19-22
: Reword Known issues item for accuracy and add actionable workaroundAvoids potentially misleading “Node’s register hook” phrasing and gives users next steps.
Apply this diff:
- - Certain OpenTelemetry instrumentation will not work with Bun, because Bun does not support Node's `register` hook. This means that some libraries that rely on this hook will not work with Bun. + - Some OpenTelemetry auto-instrumentations may not work with Bun because it doesn't currently implement Node's preloading/loader hooks (for example, the `-r/--require` mechanism) that these packages rely on. + Workarounds: use manual instrumentation for the affected libraries, or run your tasks with Node if you require those instrumentations.If you’d like, I can add links to the upstream Bun issue and the OpenTelemetry Node auto-instrumentation docs for reference.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
docs/config/extensions/lightpanda.mdx
(0 hunks)docs/guides/examples/lightpanda.mdx
(0 hunks)docs/guides/frameworks/bun.mdx
(1 hunks)docs/guides/frameworks/nextjs.mdx
(0 hunks)docs/guides/frameworks/supabase-edge-functions-basic.mdx
(0 hunks)docs/guides/frameworks/supabase-edge-functions-database-webhooks.mdx
(0 hunks)
💤 Files with no reviewable changes (5)
- docs/config/extensions/lightpanda.mdx
- docs/guides/frameworks/supabase-edge-functions-basic.mdx
- docs/guides/frameworks/supabase-edge-functions-database-webhooks.mdx
- docs/guides/examples/lightpanda.mdx
- docs/guides/frameworks/nextjs.mdx
🧰 Additional context used
🪛 LanguageTool
docs/guides/frameworks/bun.mdx
[grammar] ~8-~8: There might be a mistake here.
Context: ..."/snippets/framework-prerequisites.mdx"; import CliRunTestStep from "/snippets/st...
(QB_NEW_EN)
[grammar] ~9-~9: There might be a mistake here.
Context: ...Step from "/snippets/step-run-test.mdx"; import CliViewRunStep from "/snippets/st...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)