Skip to content

Cloud automation for Event Notifications content review #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

knee-na
Copy link

@knee-na knee-na commented Aug 12, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@knee-na knee-na marked this pull request as ready for review August 12, 2025 18:22
ibm_catalog.json Outdated
},
{
"role_crns": [
"crn:v1:bluemix:public:iam::::serviceRole:Manager",
"crn:v1:bluemix:public:iam::::role:Editor"
],
"service_name": "event-notifications",
"notes": "[Optional] Required if you are creating an Event Notifications Instance."
"notes": "[Optional] Required to create an instance of Event Notifications."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not optional

Suggested change
"notes": "[Optional] Required to create an instance of Event Notifications."
"notes": "Required to create an instance of Event Notifications."

Ak-sky
Ak-sky previously approved these changes Aug 19, 2025
Copy link
Member

@Ak-sky Ak-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ak-sky
Copy link
Member

Ak-sky commented Aug 20, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Aug 21, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Aug 21, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Aug 22, 2025

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants