Serialize IRs alongside flatbuffers #947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
commented
Aug 6, 2025
| std::move(original_mlir_code), std::move(executable_name), | ||
| m_module_builder->getNumPartitions(), | ||
| std::move(original_mlir_code), | ||
| std::move(m_module_builder->getTTIRMlirCode()), |
There was a problem hiding this comment.
One questionable design decision I made: I made the string getters return a non const reference and move from that reference, leaving the ModuleBuilder with empty strings after constructing an ExecutableImage.
Arguably the interface of buildModule could be refactored to return something like std::expected or StatusOr from compile, instead of returning just the status code and storing results as it's state.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
==========================================
- Coverage 68.41% 67.47% -0.94%
==========================================
Files 25 25
Lines 1757 1808 +51
==========================================
+ Hits 1202 1220 +18
- Misses 555 588 +33 ☔ View full report in Codecov by Sentry. |
6933dff to
059032c
Compare
059032c to
d699b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
closes #932
Problem description
Perf team needs TTIR and TTNN MLIR code to be serialized alongside flatbuffer binaries.
What's changed
The compile logic was changed to store MLIR code as necessary and pass it on, all the way to SerializedExecutableInstance class.
Serialization format was changed from just the fb to a custom format that incorporates the needed IRs alongside the fb.
Python side helper function was refactored to work with the new requirements.
Checklist