-
Notifications
You must be signed in to change notification settings - Fork 15
Implements artifact caching #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update call-build and call-test
@@ -198,6 +196,7 @@ jobs: | |||
|
|||
- name: Prepare code coverage report | |||
if: steps.strings.outputs.do_codecov && (success() || failure()) | |||
continue-on-error: true # TODO fix codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue open to track this?
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: 3.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vvukomanTT added this line recently to fix this issue: #962 Is it now not needed?
@@ -51,10 +51,9 @@ jobs: | |||
secrets: inherit | |||
|
|||
build-xla: | |||
if: inputs.rebuild_xla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rebuild_xla
input parameter now be removed?
Thanks @vmilosevic I confirmed that the new artifact name format Download Glob for tt-xla workflows artifact_download_glob='*{xla-whl-release,test-reports}*' https://github.com/tenstorrent/tt-forge/blob/main/.github/actions/set-release-facts/action.yaml#L208 |
Ticket
#1076
Problem description
Implements artifact caching to avoid unnecessary rebuilds and new naming convention.
Artifacts are reused only when: not a PR, no mlir_override, and exact name match exists.
Updated artifact naming: "xla-whl-{release|codecov}[-commit_sha]" (SHA added for individual commits only).
What's changed
Renamed build.yml to call-build.yml and added artifact reuse logic
Rename test.yml to call-test.yml and updated whl download an instalation
Pass in artifact_run_id, wheel_artifact_name, build_artifact_name as inputs
Made codecoverge reporting optional to issues (TODO Fix codecov reporting)
Install gh cli in base docker image
Updated requirements.txt to install cpu only torch
Checklist
Tested with both PR and dispatch trigger events