Update JAX tests for Distilbert and Electra #1050
Open
+61
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
=======================================
Coverage 68.41% 68.41%
=======================================
Files 25 25
Lines 1757 1757
=======================================
Hits 1202 1202
Misses 555 555 ☔ View full report in Codecov by Sentry. |
2d9d76d to
d199bba
Compare
316f693 to
b4f3c76
Compare
|
I approve of this, especially the tt-forge-models uplift part that I am looking forward to - thanks! |
b4f3c76 to
655aac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
closes #1045
Problem description
update Distilbert and Electra model JAX tests to use ModelLoader & ModelVariant from tt-forge-models
Checklist
PFA logs for reference :
distilbert.log
elec_base_discrim.log
elec_base_generator.log
elec_large_discrim.log
elec_small_discrim.log