Remove '|| true' from 'docker compose up' in ci #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'fixtures' service no longer exits, so we don't have to ignore an unsuccessful exit code
There was a problem hiding this comment.
Pull Request Overview
This PR removes the || true fallback from the Docker Compose command in the CI merge queue workflow, allowing the command to fail naturally if containers exit unsuccessfully. The change reflects that the 'fixtures' service no longer exits, eliminating the need to ignore unsuccessful exit codes.
- Removes the
|| truefallback from the Docker Compose up command - Removes the explanatory comment about handling container exit codes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
virajmehta
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'fixtures' service no longer exits, so we don't have to ignore an unsuccessful exit code
Important
Remove '|| true' from 'docker compose' in
.github/workflows/merge-queue.ymlas 'fixtures' service no longer exits..github/workflows/merge-queue.yml.This description was created by
for ebc1d04. You can customize this summary. It will automatically update as commits are pushed.