Skip to content

Update gateway.rs #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Update gateway.rs #2886

merged 2 commits into from
Jul 21, 2025

Conversation

GabrielBianconi
Copy link
Member

@GabrielBianconi GabrielBianconi commented Jul 21, 2025

Important

Update deprecation warning message in gateway.rs and corresponding test in tests.rs to suggest using [gateway.template_filesystem_access.enabled].

  • Behavior:
    • Update deprecation warning message in load() of UninitializedGatewayConfig in gateway.rs to suggest using [gateway.template_filesystem_access.enabled] instead of [gateway.template_filesystem_access].
  • Tests:
    • Update test test_deprecated_enable_template_filesystem_access in tests.rs to check for the updated deprecation warning message.

This description was created by Ellipsis for 1c7084b. You can customize this summary. It will automatically update as commits are pushed.

@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 18:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates a deprecation warning message in the gateway configuration module to improve clarity and accuracy for users migrating from the deprecated configuration option.

  • Updates the deprecation warning message format and provides more precise migration guidance
  • Corrects the suggested replacement configuration path from [gateway.template_filesystem_access] to [gateway.template_filesystem_access.enabled]

virajmehta
virajmehta previously approved these changes Jul 21, 2025
@virajmehta virajmehta enabled auto-merge July 21, 2025 18:08
@virajmehta virajmehta added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@virajmehta virajmehta added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@Aaron1011 Aaron1011 added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit be97d64 Jul 21, 2025
29 checks passed
@Aaron1011 Aaron1011 deleted the GabrielBianconi-patch-5 branch July 21, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants