fixed error handling so UI grabs right field to display #2772
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBianconi
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under the current
mainprior to this PR I got an error that logged this:but then saw "Failed" as the message on the screen. I have now fixed this.
here is what you get now:
not pretty, but much more useful
Important
Fix error handling to display detailed error messages in UI by updating
main.rsandclient.ts.main.rs, changejob.val["status"]to "failed" andjob.val["error"]to include detailed error message.client.ts, updateNativeSFTJobto stringifyjobStatus.errorfor "failed" status, ensuring detailed error message is displayed in UI.client.tsto handle error message formatting.This description was created by
for cb2e30b. You can customize this summary. It will automatically update as commits are pushed.