Skip to content

remove address check #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

remove address check #1030

merged 1 commit into from
Aug 15, 2025

Conversation

THardy98
Copy link
Contributor

What was changed

Remove check for address in config. Allows for users to call to_client_connect_config and override this value themselves. The Client.connect call already does this validation for us.

Makes it easy in the general case where users just want to do:

config = ClientConfig.load_client_connect_config()
config.setdefault("target_host", "localhost:7233")
Client.connect(**config)
  1. How was this tested:
    No tests

  2. Any docs updates needed?
    No

@THardy98 THardy98 requested a review from a team as a code owner August 15, 2025 19:51
@THardy98 THardy98 merged commit e9d8c1a into main Aug 15, 2025
26 of 28 checks passed
@THardy98 THardy98 deleted the revert_envconfig_address_check branch August 15, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants