Add tests for update-with-start reattach behavior #1000
Merged
+275
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad2935b to
891bdf2
Compare
891bdf2 to
05c0cde
Compare
05c0cde to
a844cac
Compare
|
|
||
| @workflow.signal | ||
| async def unblock_update(self): | ||
| self._unblock_update.set() |
There was a problem hiding this comment.
Bug: Non-Deterministic Workflow Synchronization
The WorkflowWithUpdate class uses asyncio.Event() for synchronization, which is not workflow-safe. This violates Temporal's determinism requirements, leading to non-deterministic replay behavior (e.g., workflows hanging) because asyncio.Event objects do not persist state across replays. Workflows should use workflow-safe primitives like workflow.wait_condition() with boolean flags.
Locations (1)
tconley1428
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests double-checking update-with-start reattach semantics. These are already covered by server integration tests. See e.g. temporalio/temporal#7693 and subsequent PRs.