[OptionsResolver] Update nested options examples to use setOptions instead of setDefault
#20719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Mar 4, 2025
|
|
||
| Defining nested option via :method:`Symfony\\Component\\OptionsResolver\\OptionsResolver::setDefault` | ||
| was deprecated since Symfony 7.3, use the :method:`Symfony\\Component\\OptionsResolver\\OptionsResolver::setOptions` | ||
| instead. Allowing to define default values for prototyped options. |
There was a problem hiding this comment.
I'm not sure about this deprecation block. Is it needed in this case, or would the replacement + versionadded note be enough?
There was a problem hiding this comment.
Yes, sometimes it's difficult to decide if we should add such a block. At the end, I left it so anyone searching for "setDefault" can still find this page. Thanks!
|
Yonel, thanks for this nice contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20705
PR symfony/symfony#59618