Skip to content

[Serializer] Fix XML example of ignoring an attribute redux #17327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

[Serializer] Fix XML example of ignoring an attribute redux #17327

merged 1 commit into from
Oct 5, 2022

Conversation

likeuntomurphy
Copy link
Contributor

This effectively reopens #16824, which could not be reopened because of a rebase after the PR was closed.

@carsonbot carsonbot added this to the 5.4 milestone Oct 4, 2022
@likeuntomurphy likeuntomurphy mentioned this pull request Oct 4, 2022
Closed
HeahDude
HeahDude approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@javiereguiluz
Copy link
Member

Jonathan, thanks for this contribution and for your patience during the review process. Congrats also on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 1e071d5 into symfony:5.4 Oct 5, 2022
@likeuntomurphy likeuntomurphy deleted the serializer-xml-change-ignore-to-attribute branch October 5, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

+1 more reviewer

@HeahDude HeahDude HeahDude approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@likeuntomurphy @javiereguiluz @xabbuh @HeahDude @carsonbot