Skip to content

Conversation

javiereguiluz
Copy link
Member

Fixes #16492.

@flack
Copy link

flack commented Mar 26, 2022

I don't think this is correct: What I implemented in symfony/symfony#45376 is only support for the old-timey background="" attribute, not for CSS background-image (see also the PR description). It could be added realtively easily and it would certainly be nice to have, but it's not implemented as of now

@javiereguiluz
Copy link
Member Author

@flack thanks for telling me about this error. I've fixed it in b39f0de Cheers!

@flack
Copy link

flack commented Mar 28, 2022

@javiereguiluz sorry, but that's still not right. What I implemented was only support for this:

<div background="cid:some-img.png"></div>

So really the HTML attribute background, not the CSS property by the same name

@javiereguiluz
Copy link
Member Author

javiereguiluz commented Mar 28, 2022

@flack fixed again! Thanks.

See 868e311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants