Skip to content

Adding docs about Request::toArray() #14325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2020
Merged

Adding docs about Request::toArray() #14325

merged 1 commit into from
Oct 3, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 3, 2020

This will fix #14323.

The related PR is found here: symfony/symfony#38224

@OskarStark OskarStark added this to the 5.2 milestone Oct 3, 2020
@wouterj wouterj merged commit 5a1d507 into symfony:master Oct 3, 2020
wouterj added a commit that referenced this pull request Oct 3, 2020
@wouterj
[#14325] Moved contents out of versionadded directive
b515661
@Nyholm
Copy link
Member Author

Nyholm commented Oct 3, 2020

Thank you for the review and merge

@wouterj
Copy link
Member

wouterj commented Oct 3, 2020 •
edited
Loading

Thanks Tobias!

I've slightly changed this in b515661 . Versionadded directive should not contain "new" information, we often automatically remove them when the version reaches end of life.

@Nyholm Nyholm deleted the 14323-toarray branch October 3, 2020 13:13
@Nyholm
Copy link
Member Author

Nyholm commented Oct 3, 2020

Okey. I see. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lyrixx lyrixx lyrixx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[HttpFoundation] Add Request::toArray() for JSON content
5 participants
@Nyholm @wouterj @lyrixx @OskarStark @carsonbot