Skip to content

Add stateless route attribute documentation #13344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2020
Merged

Add stateless route attribute documentation #13344

merged 1 commit into from
Apr 18, 2020

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Mar 14, 2020 •
edited by wouterj
Loading

Fixes #13281, Fixes #13254, Fixes #13464

@mtarld mtarld mentioned this pull request Mar 14, 2020
Merged
@mtarld mtarld force-pushed the feature/stateless branch from 43f0645 to 2102e2a Compare March 14, 2020 16:00
OskarStark
OskarStark reviewed Mar 18, 2020
View reviewed changes
@mtarld mtarld force-pushed the feature/stateless branch from 2102e2a to 740b209 Compare March 19, 2020 06:57
@nicolas-grekas
Copy link
Member

Should be updated to fix #13464 also.

javiereguiluz
javiereguiluz reviewed Apr 2, 2020
View reviewed changes
wouterj
wouterj reviewed Apr 4, 2020
View reviewed changes
@wouterj
Copy link
Member

wouterj commented Apr 4, 2020 •
edited
Loading

Should be updated to fix #13464 also.

Fyi (@mtarld), I've updated the PR description to include this. I think the current text covers the behavior in this PR more enough, so no need to update the changes in this PR :)

@mtarld mtarld force-pushed the feature/stateless branch from 740b209 to eb9de96 Compare April 4, 2020 18:04
HeahDude
HeahDude suggested changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this great feature and documenting it! I propose some tweaks though, let me know what you think.

@mtarld mtarld force-pushed the feature/stateless branch from 0bfe906 to 463c49d Compare April 12, 2020 07:45
HeahDude
HeahDude reviewed Apr 12, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Again some minor comments, let me know

@mtarld mtarld force-pushed the feature/stateless branch from 463c49d to fce0f86 Compare April 12, 2020 21:08
HeahDude
HeahDude approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtarld mtarld force-pushed the feature/stateless branch from fce0f86 to e72420d Compare April 13, 2020 07:41
@HeahDude
Copy link
Contributor

Thank you Mathias.

@HeahDude HeahDude merged commit 1b6e315 into symfony:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@OskarStark OskarStark OskarStark left review comments

@wouterj wouterj wouterj approved these changes

+1 more reviewer

@HeahDude HeahDude HeahDude approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
No milestone
7 participants
@mtarld @nicolas-grekas @wouterj @HeahDude @javiereguiluz @OskarStark @carsonbot