Skip to content

[Security] Document the remember_me.service option #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

[Security] Document the remember_me.service option #13049

merged 1 commit into from
Feb 5, 2020

Conversation

javiereguiluz
Copy link
Member

Fixes #13046.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 4, 2020
HeahDude
HeahDude reviewed Feb 4, 2020
View reviewed changes
security/remember_me.rst
@@ -132,6 +132,15 @@ The ``remember_me`` firewall defines the following configuration options:
Defines the service id of a token provider to use. If you want to store tokens
in the database, see :ref:`remember-me-token-in-database`.

``service`` (default value: ``null``)
Defines the ID of the service used to handle the Remember Me feature. It's
mostly useful in complex applications that need to override the default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove complex, even the whole sentence maybe.

Copy link
Contributor

@OskarStark OskarStark Feb 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some adjustments: bbfdec1

@OskarStark
Copy link
Contributor

Thank you Javier.

OskarStark added a commit that referenced this pull request Feb 5, 2020
@OskarStark
feature #13049 [Security] Document the remember_me.service option (ja…
cbf621e 
…viereguiluz)

This PR was merged into the master branch.

Discussion
----------

[Security] Document the remember_me.service option

Fixes #13046.

Commits
-------

7f021b5 [Security] Document the remember_me.service option
@OskarStark OskarStark merged commit 7f021b5 into symfony:master Feb 5, 2020
OskarStark added a commit that referenced this pull request Feb 5, 2020
@OskarStark
minor. refs #13049
bbfdec1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

+1 more reviewer

@HeahDude HeahDude HeahDude left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[SecurityBundle] add "service" option in remember_me firewall
4 participants
@javiereguiluz @OskarStark @HeahDude @carsonbot