Skip to content

[DependencyInjection] throw when a service's id a non-existing FQCN #61541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

[DependencyInjection] throw when a service's id a non-existing FQCN #61541

merged 1 commit into from
Aug 27, 2025
+5 −13

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 27, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 8.0 milestone Aug 27, 2025
GromNaN
GromNaN requested changes Aug 27, 2025
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test to uncomment to cover this code:

symfony/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveClassPassTest.php

Lines 100 to 104 in f6e37ef

public function testInvalidClassNameDefinition()
{
// $this->expectException(InvalidArgumentException::class);
// $this->expectExceptionMessage('Service id "Acme\UnknownClass" looks like a FQCN but no corresponding class or interface exists. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class or interface.');
$this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: Service id "Acme\UnknownClass" looks like a FQCN but no corresponding class or interface exists. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class or interface.');

#61270

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit cbcb165 into symfony:8.0 Aug 27, 2025
7 of 10 checks passed
@xabbuh xabbuh deleted the pr-61270 branch August 27, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @GromNaN @carsonbot