[DoctrineBridge] add support for ClassLocator
#61538
Open
+154
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fac4257 to
1b5a0c6
Compare
In the scope of doctrine/persistence#433 (available from `doctrine/persistence` >= 4.1) there was added `ColocatedMappingDriver::$classLocator`, which allows passing any instance of `ClassLocator` for the mapping driver to use. This commit integrates those changes into `AbstractDoctrineExtension`, used by respective ORM, MongoDB-ODM, PHPCR-ODM bundles. The solution registers a "mapping_class_finder" service that can be used by the client code to customize class finding logic. The changes come into play starting with doctrine/persistence >= 4.1, and the actual registration happens only if `AttributeDriver` supports `ClassLocator`. Dependent libraries would adhere to the same interface, where `ClassLocator` is in the first argument. The changes were introduced for: - ORM: doctrine/orm#12131; - ODM: doctrine/mongodb-odm#2802; - PHPCR ODM: doctrine/phpcr-odm#875.
1b5a0c6 to
ad2b74b
Compare
GromNaN
reviewed
Aug 28, 2025
|
|
||
| // It's possible that doctrine/persistence:^4.1 is installed with the older versions of ORM/ODM. | ||
| // In this case it's necessary to check for actual driver support. | ||
| if (!$parameterType->isIdentifiedBy(ClassLocator::class)) { |
There was a problem hiding this comment.
What's the behavior when ClassLocator does not exist (persistence version < 4.1) but the driver constructor is updated? We need this condition to be true.
I see that interface_exist(ClassLocator) is already checked in registerMappingDrivers.
| $finderService = $this->getObjectManagerElementName($driverName.'_mapping_class_finder'); | ||
|
|
||
| if ($container->hasDefinition($finderService)) { | ||
| $finderDefinition = $container->getDefinition($finderService); |
There was a problem hiding this comment.
If the service has already be declared in the application, it should not be modified. Otherwise I fail to see the purpose of customizing this service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for
ClassLocator, added to Persistence in doctrine/persistence#433, integrated into ORM in doctrine/orm#12131, and ODM doctrine/mongodb-odm#2802.The new
AttributeDrivercan now acceptClassLocatorinstead of$pathsarray:The PR introduces a new
ClassLocatorservice$driverName.'_mapping_class_locator'that will be used in theAttributeDriver.Also it registers
Finderservice$driverName.'_mapping_class_finder'that is needed for the locator to operate:This is an otherwise identical
Finder-based alternative forFileClassLocator::createFromDirectories().The changes opt in if the installed ORM/ODM libraries support it (
doctrine/persistence >= 4.1,doctrine/orm >= 3.6,doctrine/mongodb-odm >= 2.12).Replacing the
arrayargument in$mappingDriverDefwithnew Reference($classLocator)could be considered a Breaking Change, since one could've modified the array of paths afterwards; however, it's unlikely that anybody used a Compiler Pass to modify it - GitHub search found no occurrences of it.