Skip to content

[HttpKernel] Handle an array vary header in the http cache store for … #61518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 6.4
Choose a base branch
from
Open

[HttpKernel] Handle an array vary header in the http cache store for … #61518

wants to merge 1 commit into from
+31 −4

Conversation

philpichet
Copy link

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

We can have multiple vary on a response :

< HTTP/1.1 200 OK
< Content-Type: application/json
< Vary: Accept-Encoding
< Vary: Foo
< Content-Length: 1234

But if we make several calls with different value for the header Foo, we don't check them and remove the previous responses.

This fix has the purpose to check all values to keep previous call

Releated to #14635

@carsonbot carsonbot added this to the 6.4 milestone Aug 25, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@philpichet
Copy link
Author

After some research, the 'best' practice is to send only one raw with all value comma separated. But I found that Symfony handle some values of Vary by default.

Should I also open a PR to send only one row ?

@philpichet philpichet force-pushed the fix/check-all-values-vary-headers branch from c48e839 to d3d1637 Compare August 25, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpKernel Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@philpichet @carsonbot