[SecurityHttp] Removes final keyword from IsGranted attribute #61504
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Aug 23, 2025
|
Thank you @crtl. |
faa0ea1 to
3392f34
Compare
|
This won't work. The API used by the IsGrantedAttributeListener does not support using attributes of a child class, so this feature is broken. |
|
@stof is right. Let's revert the PR. If we want to un-finalize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times the same set of rules is reused many times across a project making it tedious having to manually add the attributes with their specific configuration.
Making
#[IsGranted]nonfinalallows developers to implement custom attributes like#[IsAdmin]etc. in their projects.