[Notifier] Add tests for option classes #61496
Open
+726
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Aug 21, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
- Add tests for Firebase notification options (Android, iOS, Web) - Add tests for LinkedIn, RocketChat, Telegram, and Zulip options - Ensure consistent test coverage across all notifier bridges
Replace multiple assertArrayHasKey assertions with single assertSame for better readability and maintainability
Ensure expected value is the first argument and actual value is the second argument in assertSame() calls for better error messages
5a00b71 to
72de613
Compare
OskarStark
commented
Aug 21, 2025
src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramOptionsTest.php
Outdated
Show resolved
Hide resolved
|
Failures are related. |
- Fix Telegram InlineKeyboardButton import path and use inlineKeyboard() method - Update LinkedIn test expectations to include attributes array and fix AuthorShare constructor - Update RocketChat test expectations to match current empty array behavior
fixed @nicolas-grekas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.