[Security] Ignore target route when exiting impersonation #61486
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 21, 2025
alexandre-daubois
approved these changes
Aug 21, 2025
OskarStark
approved these changes
Aug 22, 2025
fabpot
approved these changes
Aug 22, 2025
|
Thank you @MatTheCat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user impersonation documentation just mentions
Now, given that Twig’s
impersonation_exit_pathandimpersonation_exit_urlhave anexitToparameter but notimpersonation_pathnorimpersonation_url, it looks liketarget_routeshould only be used when starting an impersonation. However it is currently also used when exiting, which means that if you configured one, anexitToargument wouldn’t have any effect.Based on this assumption, this PR ignores
target_routewhen exiting impersonation.Since
exitTowill now work withtarget_routethis PR technically breaks BC, but since this behavior was broken I’m not sure it needs to be considered.