[PhpUnitBridge] revert patching of PHPUnit about memleak reports #61476
Conversation
The corresponding patch has been released for all relevant PHPUnit versions.
|
What about keeping the code? Maybe it could help some project upgrade more easily? |
|
Why would a project run their testsuite on PHP 8.5 (which is not released yet) without using the latest patch release of their PHPUnit version ? I don't see why phpunit-bridge should maintain code covering that weird case (phpunit-bridge installs the latest version anyway AFAICT) |
Well, someone still stuck on 12.0, 12.1, 12.2 for whatever reason would not get the patch. But I also doubt that in this someone would update to PHP 8.5. Patching vendor code instead always bears the risk of breaking things inadvertently. The theoretical benefit of keeping it doesn’t outweigh that for me. |
|
Thank you @xabbuh. |
reverts #61469, sebastianbergmann/phpunit@0eae114 is part of PHPUnit 8.5.44, 9.6.25, 10.5.53, 11.5.34 and 12.3.6