-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Messenger] Add ListableReceiverInterface support to RedisReceiver #61462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mudassaralichouhan
wants to merge
8
commits into
symfony:7.4
Choose a base branch
from
mudassaralichouhan:feature/redis-receiver-listable-interface
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Messenger] Add ListableReceiverInterface support to RedisReceiver #61462
mudassaralichouhan
wants to merge
8
commits into
symfony:7.4
from
mudassaralichouhan:feature/redis-receiver-listable-interface
+697
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e support to RedisReceiver (mudassarali) This PR adds support for the ListableReceiverInterface to the Redis Messenger transport. * RedisReceiver now implements ListableReceiverInterface * New methods: all() for listing messages, find() for finding by ID * Uses Redis XRANGE commands for efficient message retrieval * Fully tested with comprehensive unit and functional tests * Backward-compatible, no breaking changes * Enables integration with monitoring tools like zenstruck/messenger-monitor-bundle
This comment has been minimized.
This comment has been minimized.
fabpot
requested changes
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, I just have CS-related comments.
src/Symfony/Component/Messenger/Bridge/Redis/Transport/RedisReceiver.php
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/RedisReceiver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/RedisReceiver.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabien Potencier <fabien@potencier.org>
…ceiver.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
…ion.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
…ion.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
…ceiver.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
- Replace hardcoded Relay\Exception references with conditional exception handling - Use PHPDoc annotations for Relay types to avoid Psalm UndefinedClass errors - Maintain runtime Relay support while making type annotations Psalm-friendly - Move ListableReceiverInterface entry from 7.3 to 7.4 section per maintainer feedback - Simplify functional test to avoid complex mocking issues - All tests passing, Psalm-compliant, ready for CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
ListableReceiverInterface
to the Redis Messenger transport. It allows listing and finding messages in Redis-backed queues, enabling integrations with tools likezenstruck/messenger-monitor-bundle
.Features
RedisReceiver
now implementsListableReceiverInterface
Connection
:findAll()
,find($id)
Usage