[DoctrineBridge] remove deprecated nullable option from primary key columns #61450
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @xabbuh. |
|
Did these attributes trigger the deprecation? It was my understanding that we've deprecated that setting for many-to-many relations only because it does not make sense to have nullable join columns on a join table. /cc @greg0ire |
yes, see https://github.com/symfony/symfony/actions/runs/17033331265/job/48280266743#step:8:155 |
|
@derrabus it was not only nullable join columns on a join table, it was also to-one join columns that are part of the identifier (and so end up being part of the primary key). |
|
Right, they join column is part of the PK here. I missed hat. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see doctrine/orm#12126