[Serializer][Validator] Make internal properties private #61449
Merged
+61
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Aug 18, 2025
| if ($constraint->traverse) { | ||
| $this->traversalStrategy = TraversalStrategy::IMPLICIT; | ||
| } else { | ||
| $this->traversalStrategy = TraversalStrategy::NONE; |
There was a problem hiding this comment.
$cascadingStrategy and $cascadingStrategy are now private properties, so we have to duplicate them in this child class, and copy/paste the code that updates them (this case for the Valid constraint is the only one)
2ca3446 to
9798863
Compare
dunglas
approved these changes
Aug 18, 2025
317df75 to
917a4b2
Compare
alexandre-daubois
approved these changes
Aug 18, 2025
72d2b18 to
18ade30
Compare
18ade30 to
6388b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new
__serializeimplementations, we can finally replace those@internalproperties by private ones, without breaking either child classes still implementing__sleepnor payloads created before.