[Validator] Optimize serialized metadata and cleanup tests #61448
+186
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba2aaf8 to
8076f0b
Compare
nicolas-grekas
commented
Aug 18, 2025
| 'constraintsByGroup' => $this->constraintsByGroup, | ||
| 'traversalStrategy' => $this->traversalStrategy, | ||
| 'autoMappingStrategy' => $this->autoMappingStrategy, | ||
| return array_filter(parent::__serialize() + [ |
There was a problem hiding this comment.
use array_filter to remove properties that are still at their default values.
| $constraint->addImplicitGroupName($this->getDefaultGroup()); | ||
| $member->addConstraint($constraint); |
There was a problem hiding this comment.
Instead of accessing constraintsByGroup directly
| @@ -183,10 +183,14 @@ public function addConstraint(Constraint $constraint): static | |||
| return $this; | |||
| } | |||
|
|
|||
| $this->constraints[] = $constraint; | |||
| if (!\in_array($constraint, $this->constraints, true)) { | |||
There was a problem hiding this comment.
enables adding a constraint twice to bind it to new groups
used by ClassMetadata on L377
| @@ -310,8 +310,6 @@ public function getTargets(): string|array | |||
|
|
|||
| /** | |||
| * Optimizes the serialized value to minimize storage space. | |||
| * | |||
| * @internal | |||
There was a problem hiding this comment.
Not needed anymore, __serialize is what the engine provides to hook on serialization, we cannot "privatize" it IMHO
035d763 to
bd5c311
Compare
bd5c311 to
9f9c52a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests rely on direct access to
@internalproperties that come with notices like:This should also apply to test cases.
Also, now that we use
__serialize, we can also make these properties private. I'll propose it in a follow up PR.(failures unrelated)