Skip to content

[Notifier][Telegram] Add TelegramOptions::messageThreadId() #61444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

[Notifier][Telegram] Add TelegramOptions::messageThreadId() #61444

merged 1 commit into from
Aug 19, 2025
+15 −0

Conversation

MKC-MKC
Copy link
Contributor

@MKC-MKC MKC-MKC commented Aug 17, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues #61443
License MIT

Telegram has long supported thread based messages.
This PR adds an option to enable that support.

Use this method like this:

$options = new TelegramOptions()
	->messageThreadId($_ENV["YOU_THREAD_ID_HERE"]) // <== LIKE THIS
	->parseMode(TelegramOptions::PARSE_MODE_HTML);

@MKC-MKC MKC-MKC requested a review from OskarStark as a code owner August 17, 2025 10:39
@carsonbot carsonbot added this to the 7.4 milestone Aug 17, 2025
@carsonbot carsonbot changed the title Add messageThreadId option Add messageThreadId option Aug 17, 2025
@carsonbot carsonbot changed the title Add messageThreadId option [Notifier] Add messageThreadId option Aug 17, 2025
fabpot
fabpot requested changes Aug 19, 2025
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document this new feature in the bridge README file?

@symfony symfony deleted a comment from carsonbot Aug 19, 2025
@nicolas-grekas nicolas-grekas changed the title [Notifier] Add messageThreadId option [Notifier] Add TelegramOptions::messageThreadId() Aug 19, 2025
@OskarStark OskarStark changed the title [Notifier] Add TelegramOptions::messageThreadId() [Notifier][Telegram] Add TelegramOptions::messageThreadId() Aug 19, 2025
OskarStark
OskarStark reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test to adjust? If not, can you please add one like for the other option classes in other bridges? Thanks

@fabpot fabpot force-pushed the feature/add-telegram-thread-options branch from 5e92dc2 to 5437d9e Compare August 19, 2025 15:49
@fabpot
Copy link
Member

fabpot commented Aug 19, 2025

Thank you @MKC-MKC.

@fabpot fabpot merged commit 4f2ed0c into symfony:7.4 Aug 19, 2025
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
5 participants
@MKC-MKC @fabpot @nicolas-grekas @OskarStark @carsonbot